search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.84k stars 2.6k forks source link

Playwrite: `primary_language` added #7853

Closed vv-monsalve closed 2 weeks ago

vv-monsalve commented 3 weeks ago

This PR adds the primary_language metadata field to the Playwrite fonts.

github-actions[bot] commented 3 weeks ago

FontBakery report

fontbakery version: 0.12.7

Check results

[16] PlaywriteZA[wght].ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
* 🔥 **FAIL**

Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".

[code: missing]
⚠️ WARN Check for points out of bounds.
* ⚠️ **WARN**

The following glyphs have coordinates which are out of bounds: * ('quotedblleft', 487, 986) * ('quotedblleft', 487, 975) * ('quotedblleft', 487, 971) * ('quotedblright', 474, 983) * ('quotedblright', 474, 965) * ('quotedblright', 474, 936) * ('Atilde', 678, 1243) * ('Atilde', 713, 1243) * ('Atilde', 731, 1243) * ('Abrevehookabove', 589, 1474) and 59 more.

Use -F or --full-lists to disable shortening of long lists.

This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.

[code: points-out-of-bounds]
⚠️ WARN Glyph names are all valid?
* ⚠️ **WARN**

The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit: circumflexcomb_hookabovecomb.case

[code: legacy-long-names]
⚠️ WARN Font has **proper** whitespace glyph names?
* ⚠️ **WARN**

Glyph 0x00A0 is called "nbspace": Change to "uni00A0"

[code: not-recommended-00a0]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̌ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kpelle, Guinea (Latn, 622,000 speakers), Ekpeye (Latn, 226,000 speakers), Aghem (Latn, 38,843 speakers), Mfumte (Latn, 79,000 speakers), Cicipu (Latn, 44,000 speakers), Nateni (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ngbaka (Latn, 1,020,000 speakers), Basaa (Latn, 332,940 speakers), Dan (Latn, 1,099,244 speakers), Ebira (Latn, 2,200,000 speakers), Sar (Latn, 500,000 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Ejagham (Latn, 120,000 speakers), Gulay (Latn, 250,478 speakers), Avokaya (Latn, 100,000 speakers), Ma’di (Latn, 584,000 speakers), Zapotec (Latn, 490,000 speakers), Nzakara (Latn, 50,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Mango (Latn, 77,000 speakers), Vute (Latn, 21,000 speakers), Kom (Latn, 360,685 speakers), Koonzime (Latn, 40,000 speakers), Bafut (Latn, 158,146 speakers), Southern Kisi (Latn, 360,000 speakers), South Central Banda (Latn, 244,000 speakers), Navajo (Latn, 166,319 speakers), Bete-Bendi (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Fur (Latn, 1,230,163 speakers), Yala (Latn, 200,000 speakers), Mundani (Latn, 34,000 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese
  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese
  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
  • U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
  • U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
  • U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
  • U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
  • U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN Ensure variable fonts include an avar table.
* ⚠️ **WARN**

This variable font does not have an avar table.

[code: missing-avar]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
* ⚠️ **WARN**

We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.932x (1932)

[code: bad-hhea-range]
ℹ️ INFO Check if OS/2 xAvgCharWidth is correct.
* ℹ️ **INFO**

OS/2 xAvgCharWidth is 671 but it should be 673 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at https://github.com/fonttools/fontbakery/issues/1622

[code: xAvgCharWidth-close]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/playwriteza

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/playwriteza/PlaywriteZA[wght].ttf
Dehinted Size 335.5kb
Hinted Size 335.5kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ℹ️ **INFO**

Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu

[code: dlng-tag] * ℹ️ **INFO**

Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu

[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 7 49 9 182 0
0% 0% 0% 3% 20% 4% 73% 0%

Note: The following loglevels were omitted in this report: