Noto Sans Psalter Pahlavi: Version 2.003; ttfautohint (v1.8.4.7-5d5b) added - Githubissues

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts

https://fonts.google.com

17.82k stars 2.6k forks source link

Noto Sans Psalter Pahlavi: Version 2.003; ttfautohint (v1.8.4.7-5d5b) added #7857

Closed simoncozens closed 2 weeks ago

simoncozens commented 2 weeks ago

Taken from the upstream repo https://github.com/notofonts/psalter-pahlavi at commit https://github.com/notofonts/psalter-pahlavi/commit/67ed6002f772c9b7cea9c8d56c28e2fe65bd114d.

PR Checklist:

[x] Family categorization tags collected from the type design team with the Categories Form
[ ] Minisite_url definition in the METADATA.pb file for commissioned projects
[ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
[ ] Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
[ ] Diffenator2 regression checks for revisions on all projects that are currently in production
[ ] Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
[ ] Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
[ ] Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
[ ] Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

github-actions[bot] commented 2 weeks ago

FontBakery report

fontbakery version: 0.12.7

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[3] NotoSansPsalterPahlavi-Regular.ttf

🔥 FAIL Check tabular widths don't have kerning.

* 🔥 **FAIL**

Kerning between uni00A0 and zero is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between zero and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and one is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between one and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and two is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between two and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and three is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between three and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and four is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between four and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and five is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between five and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and six is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between six and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and seven is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between seven and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and eight is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between eight and uni00A0 is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between uni00A0 and nine is 1, should be 0

[code: has-tabular-kerning] * 🔥 **FAIL**

Kerning between nine and uni00A0 is 1, should be 0

[code: has-tabular-kerning]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.

* ⚠️ **WARN**

Article page is too short!

[code: length-requirements-not-met] * ⚠️ **WARN**

Article page lacks visual assets.

[code: missing-visual-asset]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[15] NotoSansPsalterPahlavi-Regular.ttf

🔥 FAIL Does DESCRIPTION file contain broken links?

* 🔥 **FAIL**

The following links are broken in the farticle file: https://scriptsource.org/scr/Phlp (status code: 403)

[code: broken-links]

⚠️ WARN Check if each glyph has the recommended amount of contours.

* ⚠️ **WARN**

This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek    Contours detected: 3    Expected: 2

- Glyph name: uogonek   Contours detected: 2    Expected: 1

- Glyph name: aogonek   Contours detected: 3    Expected: 2

- Glyph name: uogonek   Contours detected: 2    Expected: 1

[code: contour-count]

⚠️ WARN Check math signs have the same width.

* ⚠️ **WARN**

The most common width is 572 among a set of 6 math glyphs. The following math glyphs have a different width, though:

Width = 322: minus

[code: width-outliers]

⚠️ WARN Do any segments have colinear vectors?

* ⚠️ **WARN**

The following glyphs have colinear vectors:

* u10B84 (U+10B84): L<<439.0,304.0>--<423.0,479.0>> -> L<<423.0,479.0>--<423.0,480.0>>

* u10B84 (U+10B84): L<<511.0,479.0>--<558.0,-32.0>> -> L<<558.0,-32.0>--<558.0,-34.0>>

* u10B84.fina: L<<439.0,304.0>--<423.0,479.0>> -> L<<423.0,479.0>--<423.0,480.0>>

* u10B84.fina: L<<555.0,0.0>--<558.0,-32.0>> -> L<<558.0,-32.0>--<558.0,-34.0>>

* u10B88 (U+10B88): L<<486.0,198.0>--<500.0,23.0>> -> L<<500.0,23.0>--<500.0,21.0>>

* u10B88 (U+10B88): L<<59.0,21.0>--<59.0,23.0>> -> L<<59.0,23.0>--<72.0,194.0>>

* u10B8B.init: L<<-16.0,84.0>--<56.0,84.0>> -> L<<56.0,84.0>--<56.0,84.0>>

* u10B8B.init: L<<56.0,84.0>--<56.0,84.0>> -> L<<56.0,84.0>--<61.0,84.0>>

* u10B8B.init: L<<56.0,84.0>--<61.0,84.0>> -> L<<61.0,84.0>--<103.0,84.0>>

* u10B8B.medi: L<<-16.0,84.0>--<56.0,84.0>> -> L<<56.0,84.0>--<56.0,84.0>>

* 7 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-colinear-vectors]

⚠️ WARN Do outlines contain any jaggy segments?

* ⚠️ **WARN**

The following glyphs have jaggy segments:

* u10B80.init: B<<104.0,16.0>-<74.0,3.0>-<32.0,0.0>>/L<<32.0,0.0>--<32.0,0.0>> = 4.085616779974888

[code: found-jaggy-segments]

⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.

* ⚠️ **WARN**

The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dii (Latn, 71,000 speakers), Vute (Latn, 21,000 speakers), Cicipu (Latn, 44,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Makaa (Latn, 221,000 speakers), Bafut (Latn, 158,146 speakers), Mango (Latn, 77,000 speakers), Fur (Latn, 1,230,163 speakers), Belarusian (Cyrl, 10,064,517 speakers), Navajo (Latn, 166,319 speakers), Mfumte (Latn, 79,000 speakers), Ekpeye (Latn, 226,000 speakers), Sar (Latn, 500,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ma’di (Latn, 584,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Basaa (Latn, 332,940 speakers), Zapotec (Latn, 490,000 speakers), Gulay (Latn, 250,478 speakers), Ejagham (Latn, 120,000 speakers), Mundani (Latn, 34,000 speakers), Igbo (Latn, 27,823,640 speakers), Aghem (Latn, 38,843 speakers), Ebira (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Yala (Latn, 200,000 speakers), Nateni (Latn, 100,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Nzakara (Latn, 50,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Dan (Latn, 1,099,244 speakers).

[code: soft-dotted]

⚠️ WARN Check for codepoints not covered by METADATA subsets.

* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, cherokee, math
U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, malayalam, coptic, canadian-aboriginal, tai-le, syriac, tifinagh, math
U+030A COMBINING RING ABOVE: try adding syriac 5 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, psalter-pahlavi

[code: unreachable-subsetting]

⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.

* ⚠️ **WARN**

The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo. Please consider mentioning note-worthy improvements made to the family recently.

[code: description-not-updated]

⚠️ WARN Combined length of family and style must not exceed 32 characters.

* ⚠️ **WARN**

Name ID 6 'NotoSansPsalterPahlavi-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.

[code: nameid6-too-long]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]

ℹ️ INFO List all superfamily filepaths

* ℹ️ **INFO**

ofl/notosanspsalterpahlavi

[code: family-path]

ℹ️ INFO Font contains all required tables?

* ℹ️ **INFO**

This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?

* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

* ℹ️ **INFO**

Hinting filesize impact:

	ofl/notosanspsalterpahlavi/NotoSansPsalterPahlavi-Regular.ttf
Dehinted Size	51.0kb
Hinted Size	74.6kb
Increase	23.6kb
Change	46.4 %

[code: size-impact]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

* ℹ️ **INFO**

All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
0	0	2	10	64	7	165	0
0%	0%	1%	4%	26%	3%	67%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

simoncozens commented 2 weeks ago

This release:
* Corrects the joining behaviour of numbers (#1)
* Drops the KAF after descenders (#2)
* Adds a default languagesystem