google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.82k stars 2.6k forks source link

Edu AU VIC WA NT Arrows Guides: Version 1.001 added #7873

Open simoncozens opened 1 week ago

simoncozens commented 1 week ago

Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolhandAustralia at commit https://github.com/SorkinType/VICWANTSchoolhandAustralia/commit/7ebdd5a79adca58cd18fa25d01e1b86082b18f0b.

PR Checklist:

github-actions[bot] commented 1 week ago

FontBakery report

fontbakery version: 0.12.7

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] EduAUVICWANTArrowsGuides[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
* ⚠️ **WARN**

Family metadata at ofl/eduauvicwantarrowsguides does not have an article.

[code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[21] EduAUVICWANTArrowsGuides[wght].ttf
🔥 FAIL Checking correctness of monospaced metadata.
* 🔥 **FAIL**

Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.

[code: bad-advanceWidthMax]
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
* 🔥 **FAIL**

AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)

[code: mismatch]
🔥 FAIL Whitespace glyphs have ink?
* 🔥 **FAIL**

Glyph 'space' has ink. It needs to be replaced by an empty glyph.

[code: has-ink] * 🔥 **FAIL**

Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph.

[code: has-ink]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.

[code: no-glyphset-supported]
🔥 FAIL Combined length of family and style must not exceed 32 characters.
* 🔥 **FAIL**

Variable font instance name 'Edu AU VIC WA NT Arrows Guides Regular' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 272 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long] * 🔥 **FAIL**

Variable font instance name 'Edu AU VIC WA NT Arrows Guides Medium' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 273 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long] * 🔥 **FAIL**

Variable font instance name 'Edu AU VIC WA NT Arrows Guides SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long] * 🔥 **FAIL**

Variable font instance name 'Edu AU VIC WA NT Arrows Guides Bold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 275 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long] * ⚠️ **WARN**

Name ID 6 'EduAUVICWANTArrowsGuides-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.

[code: nameid6-too-long]
🔥 FAIL Copyright notices match canonical pattern in fonts
* 🔥 **FAIL**

Copyright notices differ between name table entries and METADATA.pb.The following copyright values were found:

- Copyright 2023 The VIC WA NT School Hand Australia Project Authors (https://github.com/SorkinType/VICWANTSchoolhandAustralia): Name Table entry

- Copyright 2023 The VIC WA NT School Hand Australia Project Authors (https://github.com/SorkinType/VICWANTSchoolHandAustralia): METADATA.pb
[code: mismatch]
🔥 FAIL Check Google Fonts glyph coverage.
* 🔥 **FAIL**

Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)

- 0x0022 (QUOTATION MARK)

- 0x0023 (NUMBER SIGN)

- 0x0024 (DOLLAR SIGN)

- 0x0025 (PERCENT SIGN)

- 0x0026 (AMPERSAND)

- 0x0027 (APOSTROPHE)

- 0x0028 (LEFT PARENTHESIS)

- 0x0029 (RIGHT PARENTHESIS)

- 0x002A (ASTERISK)

- 245 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Font has correct post table version?
* ⚠️ **WARN**

Post table format 3 use has niche use case problems.Please review the check rationale for additional details.

[code: post-table-version]
⚠️ WARN Check if OS/2 xAvgCharWidth is correct.
* ⚠️ **WARN**

OS/2 xAvgCharWidth is 1131 but it should be 1181 which corresponds to the average of the widths of all glyphs in the font.

[code: xAvgCharWidth-wrong]
⚠️ WARN Are there any misaligned on-curve points?
* ⚠️ **WARN**

The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* 50 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
* ⚠️ **WARN**

We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)

[code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/eduauvicwantarrowsguides

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
* ℹ️ **INFO**

Found a git repo URL: https://github.com/SorkinType/VICWANTSchoolhandAustralia

[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
* ℹ️ **INFO**

This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/eduauvicwantarrowsguides/EduAUVICWANTArrowsGuides[wght].ttf
Dehinted Size 100.4kb
Hinted Size 100.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 8 6 49 10 175 0
0% 0% 3% 2% 20% 4% 71% 0%

Note: The following loglevels were omitted in this report:

simoncozens commented 1 week ago

Now we have the apex VF onboarded I'm going to work on the variants.

This font only contains A-Z a-z 0-9 and space, so many of the fontbakery fails are unsurprising.

emmamarichal commented 1 week ago

Numbers don't have any arrows. Is it intentional? @simoncozens @EbenSorkin

Screenshot 2024-06-21 at 12 01 24
simoncozens commented 1 week ago

Nope, that's a fix for @EbenSorkin please!

EbenSorkin commented 1 week ago

I can make those. I forget if we even have dotted ones.

-e.

On Fri, Jun 21, 2024 at 9:09 AM Simon Cozens @.***> wrote:

Nope, that's a fix for @EbenSorkin https://github.com/EbenSorkin please!

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/pull/7873#issuecomment-2182723885, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXLZF2WV2WHPAICMGWLZIQQXHAVCNFSM6AAAAABJUA5K76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSG4ZDGOBYGU . You are receiving this because you were mentioned.Message ID: @.***>