Open yanone opened 5 days ago
fontbakery version: 0.12.7
These won't break the CI job for now, but will become effective after some time if nobody raises any concern.
METADATA.pb font full_name = "Beiruti" does not match post_script_name = "Beiruti-Regular"
[code: mismatch]GF_Latin_Core glyphset:
Language | FAIL messages |
---|---|
nl_Latn (Dutch) | Shaper didn't attach Acute to J |
^ | Shaper didn't attach Acute to j |
GF_Latin_Vietnamese glyphset:
Language | FAIL messages |
---|---|
vi_Latn (Vietnamese) | Some mark glyphs were missing: ◌̛ |
GF_Arabic_Plus glyphset:
Language | FAIL messages |
---|---|
ps_Arab (Pashto) | Shaper didn't attach uni0654 to None |
^ | Shaper didn't attach uni0654 to space |
^ | Shaper didn't attach uni064E to None |
^ | Shaper didn't attach uni0650 to None |
^ | Shaper didn't attach uni064F to None |
^ | Shaper didn't attach uni064B to None |
^ | Shaper didn't attach uni064D to None |
^ | Shaper didn't attach uni064C to None |
^ | Shaper didn't attach uni0651 to None |
^ | Shaper didn't attach uni0652 to None |
^ | Shaper didn't attach uni0670 to None |
^ | Shaper didn't attach uni064E to space |
^ | Shaper didn't attach uni0650 to space |
^ | Shaper didn't attach uni064F to space |
^ | Shaper didn't attach uni064B to space |
^ | Shaper didn't attach uni064D to space |
^ | Shaper didn't attach uni064C to space |
^ | Shaper didn't attach uni0651 to space |
^ | Shaper didn't attach uni0652 to space |
^ | Shaper didn't attach uni0670 to space |
GF_Arabic_Plus glyphset:
Language | FAIL messages |
---|---|
sd_Arab (Sindhi) | Some base glyphs were missing: ڪ |
^ | Shaper produced a .notdef |
^ | .fina version of ARABIC LETTER SWASH KAF; both buffers returned .notdef=1+493 |
^ | .medi version of ARABIC LETTER SWASH KAF; both buffers returned space=1+0 |
^ | .init version of ARABIC LETTER SWASH KAF; both buffers returned space=0+0 |
GF_Arabic_Core glyphset:
Language | FAIL messages |
---|---|
ar_Arab (Arabic) | Shaper didn't attach uni0653 to None |
^ | Shaper didn't attach uni0654 to None |
^ | Shaper didn't attach uni0655 to None |
^ | Shaper didn't attach uni0653 to space |
^ | Shaper didn't attach uni0654 to space |
^ | Shaper didn't attach uni0655 to space |
^ | Shaper didn't attach uni0670 to space |
^ | Shaper didn't attach uni064B to space |
^ | Shaper didn't attach uni064C to space |
^ | Shaper didn't attach uni064D to space |
^ | Shaper didn't attach uni064E to space |
^ | Shaper didn't attach uni064F to space |
^ | Shaper didn't attach uni0650 to space |
^ | Shaper didn't attach uni0651 to space |
^ | Shaper didn't attach uni0652 to space |
^ | Shaper didn't attach uni0670 to uni0640 |
^ | Shaper didn't attach uni0653 to uni0640 |
^ | Shaper didn't attach uni0654 to uni0640 |
^ | Shaper didn't attach uni0655 to uni0640 |
^ | Shaper didn't attach uni064B to uni0640 |
^ | Shaper didn't attach uni064C to uni0640 |
^ | Shaper didn't attach uni064D to uni0640 |
^ | Shaper didn't attach uni064E to uni0640 |
^ | Shaper didn't attach uni064F to uni0640 |
^ | Shaper didn't attach uni0650 to uni0640 |
^ | Shaper didn't attach uni0651 to uni0640 |
^ | Shaper didn't attach uni0652 to uni0640 |
GF_Arabic_Core glyphset:
Language | FAIL messages |
---|---|
fa_Arab (Persian) | Shaper didn't attach uni0654 to None |
^ | Shaper didn't attach uni0654 to space |
GF_Arabic_Plus glyphset:
Language | WARN messages |
---|---|
ms_Arab (Malay (Arabic)) | No exemplar glyphs were defined for language Malay (Arabic) |
GF_Arabic_Plus glyphset:
Language | WARN messages |
---|---|
sd_Arab (Sindhi) | Some auxiliary glyphs were missing: ڪ |
Font names are incorrect:
nameID | current | expected |
---|---|---|
Family Name | Beiruti | Beiruti |
Subfamily Name | Regular | Regular |
Full Name | Beiruti | Beiruti Regular |
Postscript Name | Beiruti-Regular | Beiruti-Regular |
Typographic Family Name | Beiruti | N/A |
Typographic Subfamily Name | Regular | N/A |
Regular missing from full name
[code: lacks-regular]The following mark characters could be in the GDEF mark glyph class: Acute (U+0301), Breve (U+0306), Caron (U+030C), Cedilla (U+0327), Circumflex (U+0302), Comma.high (U+0313), Commaaccent (U+0326), Dieresis (U+0308), Dotaccent (U+0307), Dotbelow (U+0323) and 8 more.
Use -F or --full-lists to disable shortening of long lists.
[code: mark-chars]The following non-mark characters should not be in the GDEF mark glyph class: U+FC5E, U+FC5F, U+FC60, U+FC61, U+FC62 and U+FC63
[code: non-mark-chars]dcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] * ⚠️ **WARN**Lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] * ⚠️ **WARN**lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] * ⚠️ **WARN**tcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]Interpolation issues were found in the font:
- Contour 0 point 42 in glyph 'uni2126' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gcommaaccent' has a kink between location wght=200 and location wght=900
- Contour 2 start point differs in glyph 'O64C' between location wght=400 and location wght=200
- Contour 2 in glyph 'O64C': becomes underweight between wght=400 and wght=200.
- Contour 3 start point differs in glyph 'O64C' between location wght=400 and location wght=200
- Contour 3 in glyph 'O64C': becomes underweight between wght=400 and wght=200.
- Contour 4 start point differs in glyph 'O64C' between location wght=400 and location wght=200
- Contour 4 in glyph 'O64C': becomes underweight between wght=400 and wght=200.
- Contour 5 start point differs in glyph 'O64C' between location wght=400 and location wght=200
- Contour 5 in glyph 'O64C': becomes underweight between wght=400 and wght=200.
- 49 more.
Use -F or --full-lists to disable shortening of long lists.
[code: interpolation-issues]The most common width is 480 among a set of 19 math glyphs. The following math glyphs have a different width, though:
Width = 683: suchthat, notelement, element
Width = 612: proportional
Width = 929: orthogonal
Width = 1164: angle
Width = 928: uni2237
[code: width-outliers]This font has a 'Soft Hyphen' character.
[code: softhyphen]The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit: extendedarabicindicdigitfoururdu.lining and extendedarabicindicdigitsevenurdu.lining
[code: legacy-long-names]The following glyphs have a counter-clockwise outer contour:
* .notdef has a counter-clockwise outer contour
* A (U+0041) has a counter-clockwise outer contour
* AE (U+00C6) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Acircumflex (U+00C2) has a counter-clockwise outer contour
* 1841 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]No dotted circle glyph present
[code: missing-dotted-circle]The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ i̓ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌ ḭ̀ ḭ́ ḭ̄ ị̀ ị́ ị̂ ị̃ ị̄
The dot of soft dotted characters should disappear in other cases, for example: i̇ i̒ i̦̇ i̦̊ i̦̋ i̦̒ i̦̓ i̧̇ i̧̊ i̧̋ i̧̒ i̧̓ j̆ j̇ j̉ j̊ j̋ j̒ j̓ j̣̀
Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Sar (Latn, 500,000 speakers), Makaa (Latn, 221,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dan (Latn, 1,099,244 speakers), Nzakara (Latn, 50,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Kom (Latn, 360,685 speakers), Zapotec (Latn, 490,000 speakers), Avokaya (Latn, 100,000 speakers), Vute (Latn, 21,000 speakers), Gulay (Latn, 250,478 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Dii (Latn, 71,000 speakers), Igbo (Latn, 27,823,640 speakers), Nateni (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Mfumte (Latn, 79,000 speakers), Mango (Latn, 77,000 speakers), Ekpeye (Latn, 226,000 speakers), Koonzime (Latn, 40,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ebira (Latn, 2,200,000 speakers), Yala (Latn, 200,000 speakers), Fur (Latn, 1,230,163 speakers), Lugbara (Latn, 2,200,000 speakers), Dutch (Latn, 31,709,104 speakers), Ejagham (Latn, 120,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Cicipu (Latn, 44,000 speakers), South Central Banda (Latn, 244,000 speakers), Ma’di (Latn, 584,000 speakers), Mundani (Latn, 34,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Navajo (Latn, 166,319 speakers).
[code: soft-dotted]The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: arabic
, latin
, latin-ext
, menu
, vietnamese
The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.
[code: missing-eof-linebreak]GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
[code: lacks-kern-info]
This font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]This variable font does not have an avar table.
[code: missing-avar]This font file does not have a 'meta' table.
[code: lacks-meta-table]This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
Found a git repo URL: https://github.com/googlefonts/beiruti
[code: url-found]This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818
[code: lacks-EPAR]These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]💥 ERROR | ☠ FATAL | 🔥 FAIL | ⚠️ WARN | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 17 | 41 | 10 | 177 | 0 |
0% | 0% | 1% | 7% | 17% | 4% | 71% | 0% |
Note: The following loglevels were omitted in this report:
@yanone Are we ok with all the interpolations issues? Beiruti[wght].pdf
Example:
https://github.com/google/fonts/assets/64773544/dfcf0409-db41-4618-8a35-44538be20340
@yanone I'm trying to investigate about the full_name thing. I never had that issue yet!
@JuergenWillrodt
Please take a look at this PDF report two comments up from here. It shows kinky mid-way interpolations that Emma found via fonttools.
Personally I think that the dotted circle is never used in practice, so it shouldn't be a problem to have this. If you could fix that, it would still be nice.
Out of the letters I think you should have a look at all the "a" combinations incl "ae". The kink in the counter is relatively prominent if used at large sizes. One of the points changes position between the three masters; moves from the bottom to the left edge of the counter.
The kinks in the other shown letters I personally find so tiny that we can safely ignore them.
Let us know if you want to fix any of those.
@JuergenWillrodt
Please also remove the "Full Name" and "Font Name" fields from the Glyphs sources and then rebuild the UFOs. Those two don't meet our specifications.
Thank you
Taken from the upstream repo https://github.com/googlefonts/beiruti at commit https://github.com/googlefonts/beiruti/commit/1d848d465d697dc6c61782818a382b80bc78c40c.
Resolves #7625
PR Checklist: