google / fswalker

Simple file system integrity checking tooling.
https://google.github.io/fswalker/
Apache License 2.0
102 stars 12 forks source link

Fix generic comparisons on protobuf messages #22

Closed dsnet closed 5 years ago

dsnet commented 5 years ago

Generated protobuf messages contain internal data structures that general purpose comparison functions (e.g., reflect.DeepEqual, pretty.Compare, etc) do not properly compare. It is already the case today that these functions may report a difference when two messages are actually semantically equivalent.

Fix all usages by either calling proto.Equal directly if the top-level types are themselves proto.Message, or by calling cmp.Equal with the cmp.Comparer(proto.Equal) option specified. This option teaches cmp to use proto.Equal anytime it encounters proto.Message types.