search

google / fuzzbench

FuzzBench - Fuzzer benchmarking as a service.
https://google.github.io/fuzzbench/
Apache License 2.0
1.11k stars 270 forks source link

Support non-alphanumeric passwords in alembic. #1812

Open mvanotti opened 1 year ago

mvanotti commented 1 year ago

This commit modifies alembic's env.py, so that it supports non-alphanumeric passwords.

The script creates an url to connect to the database, but the passworld was not url-escaped. Passwords with characters like @, : and . were causing failures.

The password is set as a config in sqlalchemy, which uses python's string interpolation. Now we replace instances of % with %% so that passwords that contain % can be used.

Fixes issue #1801

mvanotti commented 1 year ago

This commit needs more work, I barely tested it.

DonggeLiu commented 1 year ago

This commit needs more work, I barely tested it.

I see, I will convert it to a draft for now, but feel free to convert it back once you reckon it is ready. Thanks!