This removal is necessary because retries also use logs inside of their implementation so we want to avoid the following cyclic scenario:
Log method is called
A log fails (e.g. permission issue)
The logging method uses a retry wrapper, so it tries again
The code inside the retry wrapper also calls a log method, so we go back to step 1
Before this PR, this scenario was avoided by using a log_retries parameter, that would disable loggings on retries functions when the retry was called from a log function.
This PR remove this parameter and get rid of the circular dependency by making a custom retry logic inside of the logs methods.
Removing usage of
@retry.wrap
in logs methods.This removal is necessary because retries also use logs inside of their implementation so we want to avoid the following cyclic scenario:
Before this PR, this scenario was avoided by using a
log_retries
parameter, that would disable loggings on retries functions when the retry was called from a log function.This PR remove this parameter and get rid of the circular dependency by making a custom retry logic inside of the logs methods.