search

google / fuzzbench

FuzzBench - Fuzzer benchmarking as a service.
https://google.github.io/fuzzbench/
Apache License 2.0
1.09k stars 266 forks source link

Fix saturated corpus experiment requests #1993

Closed ndrewh closed 3 months ago

ndrewh commented 4 months ago

The parser for experiment-requests.yml checks oss_fuzz_corpus:

https://github.com/google/fuzzbench/blob/421187b515cfaf4d7ad8bfe9bfa9512372dceaae/service/automatic_run_experiment.py#L64-L67

Experiment request docs say to use oss-fuzz-corpus, not oss_fuzz_corpus

https://github.com/google/fuzzbench/blob/421187b515cfaf4d7ad8bfe9bfa9512372dceaae/service/experiment-requests.yaml#L9

and all the past experiment requests are using oss-fuzz-corpus https://github.com/google/fuzzbench/blob/421187b515cfaf4d7ad8bfe9bfa9512372dceaae/service/experiment-requests.yaml#L2273-L2276

ndrewh commented 4 months ago

Alternatively, we could just change the yaml to use the underscore

jonathanmetzman commented 3 months ago

BTW note that we don't use experiment-requests.yaml. Experiments are conducted through "gcbrun" commands in PRs.

DonggeLiu commented 3 months ago

@ndrewh Sorry I just noticed that your commit failed the presubmit test, could you please fix it?

Thanks!