search

google / fuzzbench

FuzzBench - Fuzzer benchmarking as a service.
https://google.github.io/fuzzbench/
Apache License 2.0
1.09k stars 266 forks source link

revert oss_fuzz_corpus typo fix #1997

Closed ndrewh closed 3 months ago

ndrewh commented 3 months ago

This reverts #1993

the comments in experiment-requests.yml are untouchable without breaking tests

ndrewh commented 3 months ago

🤬 presubmit failed

ndrewh commented 3 months ago

Alright, I changed it to just touch the comments in experiment-requests.yml, and it still breaks tests. So i'm giving up on fixing the typo. Just reverting

DonggeLiu commented 3 months ago

Thanks for creating this, @ndrewh. May I ask if experiment-requests.yml is the only source of error when unifying the -s and _s?

I reckon there is no need to rewrite experiment-requests.yml: it will not be used/parsed/revived anytime soon.

For example, if we do a universal grep and replace to only use oss_fuzz_corpus (or oss-fuzz-corpus) expect experiment-requests.yml, would that still have CI failures?

ndrewh commented 3 months ago

Yes it is the only issue and yes it has CI failures if you try to fix

DonggeLiu commented 3 months ago

I see, that's really weird.

Sorry that it did not work out this time, but thanks again for your time. Let me merge this for now.

jonathanmetzman commented 3 months ago

Dongge I think we can just delete the test and reland.