search

google / fuzzbench

FuzzBench - Fuzzer benchmarking as a service.
https://google.github.io/fuzzbench/
Apache License 2.0
1.09k stars 266 forks source link

Move benchmark git checkout commands to Dockerfile, just after clone for readability #611

Open inferno-chromium opened 4 years ago

jonathanmetzman commented 4 years ago

combine all clones in RUN and prune to save space

Is this really a big concern? We don't force this in OSS-Fuzz. i don't want to annoy integrators with making optimal dockerfiles.

lszekeres commented 4 years ago

combine all clones in RUN and prune to save space

Is this really a big concern? We don't force this in OSS-Fuzz. i don't want to annoy integrators with making optimal dockerfiles.

I don't think it's important to prune, and definitely not something to enforce. Sorry, my comment could have been more specific: i was wondering if it'd make sense to keep the git clone and checkout commands next to each other, ie do the checkout in the Dockerfile too, eg:

RUN git clone <repo> <dir>
RUN git -C <dir> checkout <commit>

primarily for readability. I mentioned pruning as something we'd also have the option for if we did cloning and checkout together, in addition to readability.