glslang raises Warnings with GCC 8

google / gapid

Graphics API Debugger

https://gapid.dev

Apache License 2.0

2.2k stars 327 forks source link

glslang raises Warnings with GCC 8 #3100

Open yalcinmelihyasin opened 5 years ago

yalcinmelihyasin commented 5 years ago

Update glslang and see if the issue is there. If it is, then we should make a bug report and then remove the compiler flag Wno-error=class-memaccess.

hevrard commented 5 years ago

It seems to be fixed by their commit fc89f065e945b359e7c384a962640a233404d5cc

https://github.com/KhronosGroup/glslang/commit/fc89f065e945b359e7c384a962640a233404d5cc

pau-baiget commented 4 years ago

Can this be closed then? @yalcinmelihyasin @hevrard

hevrard commented 4 years ago

Not yet, we need to update glslang to a more recent commit. It is currently still pointing to an old commit: https://github.com/google/gapid/blob/a01b72076aadd05c61535911d2a115279d69c033/tools/build/workspace.bzl#L121

After updating, we'll need to remove the flag here: https://github.com/google/gapid/blob/a01b72076aadd05c61535911d2a115279d69c033/tools/build/third_party/glslang.BUILD#L49

I suggest we wait for @AWoloszyn to comment on how to update properly, because it has consequences for him.

yalcinmelihyasin commented 4 years ago

@AWoloszyn what do you think about this?