google / gasket-driver

GNU General Public License v2.0
47 stars 29 forks source link

Include DMA_BUF regardless of kernel version #10

Closed hibby50 closed 1 year ago

hibby50 commented 1 year ago

This is causing issues compiling on LTS kernels. In my case SUSE 15.5 has a kernel version of 5.14 but backports whatever broke this in the first place.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

chrBrd commented 1 year ago

@hibby50

I'm not associated with Google or the maintainer of this repository, but I am hoping to maintain the contents of this repo for openSUSE!

I'm afraid to say, however, I don't think the maintainer of this GH repo should accept this PR, and you should consider closing it...

Those conditional checks are there because the changes to the dma-buf namespace that necessitated it weren't implemented until kernel 5.16. That conditional check must be there for general use and backwards compatibility etc. Upstream can't be held responsible for any issues introduced by third-party backports.

However, things like that are very much the job of hopeful maintainers. And in that capacity your issue and the associated fix are right on the money! :grin:

So I've incorporated your patch into the package builds for Leap/SLES 15.5. 'Experimental' "hardware" repository. Hopefully that's okay with you? :slightly_smiling_face:

I'm aiming to have this become part of the official openSUSE/SLES repositories very soon.

hibby50 commented 1 year ago

Thank you @chrBrd that all makes sense. I am going to close this PR in favor of a SUSE maintained version.

Your OBS setup for this is also a lot prettier than mine haha

cyqsimon commented 11 months ago

This will be fixed by #16 (I think), just posting to notify everybody.