Closed peb-peb closed 1 year ago
To check and lint my changes, I used the following:
pylint --rcfile pylintrc --disable=W0703,R1734,R1735,C0209,C0103,R1732 src/gcp_scanner/*.py
:arrow_up: this is how we run the linting checks in our workflows.
But, this requires us to have the pylintrc
file to be present on our local system. So, can we not include it in google/gcp_scanner by default?
Also, the pytest
and pylint
tests are merged in the same workflow, which can be separated to make it more obvious on which tests the build is failing. So, should we do it this way?
Thanks for the PR. pylintrc can be downloaded from web, no need to include that file in the src tree. As for separating pytest
and pylint
, I think it is pretty straightforward in Github Actions. I'd keep it this way.
Ok! Thanks :)
Changes Made
changed f-string logging implementation to lazy % formatting for logs
Checklist
Related Issues
Issue #103
Additional Notes
The changes have been tested on my local machine for
pylint
.