google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
311 stars 97 forks source link

Refactor the "crawl.py" file to improve maintainability and organisation #108

Closed Am0stafa closed 1 year ago

Am0stafa commented 1 year ago

Description:

The crawl.py file in our project contains 31 functions and over 500 lines of code. While this file may have started out as a convenient place to put all of our crawling functions, it will become unwieldy and difficult to maintain as the project grow so it such be fixed as early as possible.

I propose refactoring crawl.py by splitting the functions into separate files based on their relation and functionality. Here are some benefits of doing so:

I propose that each file should contain a subset of related functions that perform a specific task. This will allow us to more easily reason about each file's purpose and the functions contained within it.

Related Issues

2

HarshvMahawar commented 1 year ago

I want to work on this issue. I think the main challenge to refactoring the crawl.py file would be understanding the dependencies and effective error handling of the functions in crawl.py to other code files. Are there any resources about the project structure or anything to understand the code base better? I would love to dive into those...thank you:)

mshudrak commented 1 year ago

Hi @HarshvMahawar, we have multiple PRs addressing this issue. I'd encourage you to consider other issues to work on.