search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
305 stars 94 forks source link

fix: #114 #115

Closed grumpyp closed 1 year ago

grumpyp commented 1 year ago

This PR fixes #114

All information can be read in the issue.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mshudrak commented 1 year ago

Please accept Google CLA.

grumpyp commented 1 year ago

Thanks for the hint. Done

grumpyp commented 1 year ago

The change itself looks fine. Let's finish the discussion in the issue before merging.

Gave a final statement and opened a new issue for re-evaluation in #116 . Thanks for the heads-up.