search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
311 stars 97 forks source link

Re-evaluation of the python version in Dockerfile related to #114 #116

Closed grumpyp closed 1 year ago

grumpyp commented 1 year ago

As mentioned in #114 we want to re-evaluate if the build would work with python3.11.

All related information can be found in #114 and #115

EDIT:

The issue is that there is an error during a Docker build related to the current python version in the docker file FROM python:3-slim-buster and the grpcio package. There have been suggestions to resolve the issue by installing build-essential python-dev which end up in a long build time > 20 min.

As a solution, it has been suggested to open a ticket to re-evaluate the issue after some time has passed to see if the issue has been resolved. The proposed solution is to lock to Python 3.10 for now, but re-evaluate the issue after some time has passed.

This will ensure that the issue is resolved while also avoiding the risk of locking to a specific version causing issues in the future.

I'd suggest to check again in 2 months.

ZetaTwo commented 1 year ago

Please summarise what we are re-evaluating, how and when so that this issue is self-contained. The build does work with 3.11 so that's not the issue. The issue is that currently some dependency has to be built from source which takes a long time.

grumpyp commented 1 year ago

we found a better solution using FROM python:slim-bullseye.

our whole discussion can be found here #115