google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
305 stars 95 forks source link

Installation Guide updatation for MacOS users. #131

Closed Bhardwaj-Himanshu closed 1 year ago

Bhardwaj-Himanshu commented 1 year ago

Description

There was no clear description for users which are operating on a Mac-based-machine. So I have added installation sections for those users.

Changes Made

Added sections for Creating a virtual environment and setting up that virtual environment on Mac.

Checklist

Related Issues

125 -->Here, the issue was raised first.

Additional Notes

As there is just a change of shell from moving from linux to Mac--bash-->zsh. The commands remain same as they are for linux.

Also was thinking if we could just add an OR inside the linux OR Mac--which could potentially save the lines of code, but would sacrifice clarity!

mshudrak commented 1 year ago

Hi, thanks for the commit. I don't actually see any changes related to MacOS guide.

Bhardwaj-Himanshu commented 1 year ago

Hi, thanks for the commit. I don't actually see any changes related to MacOS guide.

Can you please try checking?

Lines 54-58 Lines 74-78

And do let me know, if it still dosen't show up on your side! Thanks.

mshudrak commented 1 year ago

Sorry, my bad. LGTM.