search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
311 stars 97 forks source link

Move arguments parser into individual function #15

Closed mshudrak closed 1 year ago

mshudrak commented 1 year ago

We need to have a separate function where we parse arguments instead of doing it in the main routine.

flamesjames commented 1 year ago

Hey there @mshudrak! Does this issue still need to be addressed? If so, I would be glad to help out with it.

mshudrak commented 1 year ago

Hi! yes, we do still need that.

flamesjames commented 1 year ago

Awesome! Can you please assign the issue to me? I will review the code and let you know if I have any additional questions

flamesjames commented 1 year ago

Hello @mshudrak - Sorry for the delay, I started digging into the code and believe I see the area you'd like to consolidate into a function - it's most of the code within the main() function (roughly lines 289-360 of scanner.py), correct? Should anything else be included within the function?

mshudrak commented 1 year ago

Hello. Yes, that's correct. Basically argument parsing functionality.

flamesjames commented 1 year ago

@mshudrak do I need to start with a clean branch and re-make the changes?

mshudrak commented 1 year ago

I left a comment @flamesjames on the bug PR iteslf.

AnkitKashyap0709 commented 1 year ago

Is the issue resolved here? If not, then I'd love to complete the work here.

mshudrak commented 1 year ago

@flamesjames there is ongoing commit made by @flamesjames. You can probably cooperate in order to finish with this issue.

flamesjames commented 1 year ago

@AnkitKashyap0709 assistance would be great, thank you!