refactor hammer : implement client factory for Compute client

google / gcp_scanner

A comprehensive scanner for Google Cloud

Apache License 2.0

305 stars 95 forks source link

refactor hammer : implement client factory for Compute client #159

Closed sudiptob2 closed 1 year ago

sudiptob2 commented 1 year ago

closes #154

[x] implemented the creation of ComputeClient using the factory
[x] updated scanner.
[x] updated unit tests related to compute resources.
[x] added test for compute client factory.

sudiptob2 commented 1 year ago

thanks, agreed. I formatted the code with pycharm formatted. Also, the pylint we are using for this project approved this. But the formatting is indeed inconsistent. I will manually fix these formatting errors.

HasanZaigam commented 7 months ago

i am interested to contribute this issue you can please assign me this

mshudrak commented 7 months ago

We do not assign problem, feel free to just submit PR.