refactor 🎨: crawler/app services - Githubissues

google / gcp_scanner

A comprehensive scanner for Google Cloud

Apache License 2.0

310 stars 97 forks source link

refactor 🎨: crawler/app services #194

Closed peb-peb closed 1 year ago

peb-peb commented 1 year ago

Notes

closes #192 ref to #153

fix absolute imports from gcp_scanner. ... to src.gcp_scanner. ...
refactored the if statements to service_crawler_map.

@mxmssh @0xDeva

mshudrak commented 1 year ago

Overall looks good but could you please add tests similar to what @sudiptob2 implemented here: https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R772 and here https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R328