google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
305 stars 95 forks source link

feat: Add search through resources functionality #252

Closed yahia3200 closed 1 year ago

yahia3200 commented 1 year ago

Demo

Peek 2023-07-22 21-20

Changes Made

Additional Notes

For now, the search is done using the resource name only but this can easily be extended to different resource attributes

mshudrak commented 1 year ago

@yahia3200 could you please add a simple manual on how to run the tool in the description here? https://github.com/google/gcp_scanner#working-with-results. I want to run it to test and provide feedback.

yahia3200 commented 1 year ago

@mshudrak for now to work with the vis tool you need node.js to be installed on your system and following this steps

cd visualization_tool npm i npm run dev

As this not the way that the user should use the tool, I didn't add these steps to the repo In the future I will add a build step and bundle the tool with gcp scanner and use flask to start the tool. This is partially done but not complete yet

mshudrak commented 1 year ago

Thanks. it works for me. I am trying to load test report but it shows just "no resource found". Am I doing something wrong? I also left 2 comments/questions

yahia3200 commented 1 year ago

I saw the two comments but didn't see this one After you upload the file, did you click on the plus icon ?

mshudrak commented 1 year ago

All good, sometimes it is hard to see them :) Yes, I upload the file and clicked on plus button.

mshudrak commented 1 year ago

You can try it on your own. test.zip

yahia3200 commented 1 year ago

I made a mistake in renaming the resources in the tool and the final I'm using for demo. The tool now only parses the compute_instances and compute_disks resources not storage_buckets.

I made a commit to fix this issue and use names Compute Instance and Compute Disk instead of GCE and GCS In my plan that In the next PR the tool should parse all resources in the light_version_scan_schema