search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
304 stars 95 forks source link

fix: Append BigQuery tables instead of replacing in get_bq_tables #273

Closed ai-naymul closed 11 months ago

ai-naymul commented 11 months ago

Description

In the get_bq_tables function of the BigQueryCrawler class, the retrieved tables were overwriting the list in each iteration of the loop, resulting in the loss of previously fetched tables. This commit addresses the issue by using the extend method to append the newly retrieved tables to the existing list, ensuring that all tables are properly accumulated.

Changes Made

Fixes number

254

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ZetaTwo commented 11 months ago

Tests are failing, please have a look. Also check that the formatting is correct: https://github.com/google/gcp_scanner/blob/main/CONTRIBUTING.md#some-other-things-to-keep-in-mind-before-any-pr

ai-naymul commented 11 months ago

Tests are failing, please have a look. Also check that the formatting is correct: https://github.com/google/gcp_scanner/blob/main/CONTRIBUTING.md#some-other-things-to-keep-in-mind-before-any-pr

@ZetaTwo Could you please help me in this regarding to pass those test?

ZetaTwo commented 11 months ago

You should be able to view the test output errors here and use that to debug the issue.

ai-naymul commented 11 months ago

You should be able to view the test output errors here and use that to debug the issue.

I tried but didn't got that . Actually, I am newbie contributor it's little bit hard to debug the issue, I will be grateful if you could guide me to solve that? :)

ZetaTwo commented 11 months ago

If you look here https://github.com/google/gcp_scanner/actions/runs/5986026875/job/16240350840?pr=273 you can read the error from the test and see that the expected output is not equal to the actual output. This could be either because you have introduced a bug with your fix or because the test is wrong. You need to analyse this, understand what is going on and update your PR to fix this.

ai-naymul commented 11 months ago

If you look here https://github.com/google/gcp_scanner/actions/runs/5986026875/job/16240350840?pr=273 you can read the error from the test and see that the expected output is not equal to the actual output. This could be either because you have introduced a bug with your fix or because the test is wrong. You need to analyse this, understand what is going on and update your PR to fix this.

If you look here https://github.com/google/gcp_scanner/actions/runs/5986026875/job/16240350840?pr=273 you can read the error from the test and see that the expected output is not equal to the actual output. This could be either because you have introduced a bug with your fix or because the test is wrong. You need to analyse this, understand what is going on and update your PR to fix this.

Sorry to say that Actually I am a newbie coder so that's why I didn't get to understand the errors , I tried a lot to understand the error but couldn't got that , could you please see my code and give me further suggestion how to make the code work, I will be very grateful 🙏

ZetaTwo commented 11 months ago

Sorry, unfortunately I can not help you with that. Feel free to re-open the PR when you have some more experience and can troubleshoot the issue.