search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
304 stars 95 forks source link

Visualization Tool: Search using regex #276

Closed yahia3200 closed 8 months ago

yahia3200 commented 11 months ago

The user can search through the scanned resources using their names and IAM policy roles with emails. So one improvement is to implement another search mode where the user can search using a regex expr through resource names and other text attributes for resource.

aryanagrawal22 commented 9 months ago

Hey, do we want a separate button to enable the regex search in the search box, or something like if the search box has a valid regex expr then we find results accordingly?

mshudrak commented 9 months ago

yep, the second option sounds reasonable for me. No need for a separate button. Thanks for chiming in on this bug.

aryanagrawal22 commented 9 months ago

Understood, I have made the relevant changes and raised a PR: https://github.com/google/gcp_scanner/pull/301. Please let me know if any changes are required.