google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
304 stars 95 forks source link

Refinement: Removed Redundancy of Scan Config Passing #304

Closed aryanagrawal22 closed 8 months ago

aryanagrawal22 commented 8 months ago

Description

Note : Currently as I was checking all the crawlers, I have just seen that config is being used only inside the StorageBucketsCrawler crawler. So only its value is set as True in its base class.

Changes Made

Testing

Local testing done with logs denoting that where config file is sent and where it is not. (Removed the logs after the testing)

Screenshot 2023-11-23 at 6 01 29 PM

This check denotes that only StorageBucketsCrawler is being sent the config file

aryanagrawal22 commented 8 months ago

Thanks for your PR. I left some suggestions. PTAL.

Thank you for going through my PR, and reviewing it. I think, I have done the relevant changes as asked. Please let me know in case any others are needed.

aryanagrawal22 commented 8 months ago

Yes, fair point. I have made the changes, changed the name to has_config_dependency from crawler_config

Pushed with the changes 😁