google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
304 stars 95 forks source link

Command to activate virtual environment on windows is wrong #309

Closed dhruvpal05 closed 7 months ago

dhruvpal05 commented 7 months ago

Affected Component

Describe the bug

In INSTALL.md , in the section Build from source step 4. Activate the Virtual Environment with, on windows section .\venv\Scripts\activate.bat this command should not include .bat as .\venv\Scripts\activate\ this is the correct command for activating virtual environment on windows.

To Reproduce On windows execute the command .\venv\Scripts\activate.bat after creating the virtual environment, it will not activate the virtual environment. Instead .\venv\Scripts\activate this will activate the virtual environment.

Expected behavior

It should activate the virtual environment.

Current behavior

It does noting, and does not activate the virtual environment.

Screenshots

Screenshot (403)

As we can see nothing happens above

Screenshot (404)

Here this command activates the virtual environment.

Additional context

I can create a PR right away for this issue, if someone can review this issue and verify.

mshudrak commented 7 months ago

Hey @dhruvpal05, thanks for pointing out. Please submit PR and I will make sure to review it.

dhruvpal05 commented 7 months ago

Hey @mshudrak , made a PR #310 please review . Thank you