google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
311 stars 97 forks source link

feat: Add type annotations using the MyPy library for improved type checking and expand command names to provide more descriptive labels for better readability and clarity. #64

Closed Am0stafa closed 1 year ago

Am0stafa commented 1 year ago

Description

Added types to args along with long names for all commands

Changes Made

changes in scanner.py

Checklist

Feel free to modify and customize this template as needed to fit the specific needs of the GCP Scanner project.

peb-peb commented 1 year ago

Instead of _ in the detailed names of arguments. We should use -. Example: --service_account would become --service-account and so on.

mshudrak commented 1 year ago

@peb-peb thanks for the comments. Could you clarify why you think - is better than _?

peb-peb commented 1 year ago

I'd say it's a standard now because all the CLI tools and gcp itself follow this schema.

You can see here which also uses a similar pattern.

Also, I guess it would be easier to type out and stuff XD

Am0stafa commented 1 year ago

Yeah make sense, @mshudrak should I change it?

mshudrak commented 1 year ago

Up to you, I don't have strong preference. Why did you close PR? :) We still need to merge it

Am0stafa commented 1 year ago

@mshudrak alright all changes are done, sorry closed it by a silly mistake.

peb-peb commented 1 year ago

LGTM