Closed Am0stafa closed 1 year ago
Instead of _
in the detailed names of arguments. We should use -
.
Example: --service_account
would become --service-account
and so on.
@peb-peb thanks for the comments. Could you clarify why you think -
is better than _
?
I'd say it's a standard now because all the CLI tools and gcp itself follow this schema.
You can see here which also uses a similar pattern.
Also, I guess it would be easier to type out and stuff XD
Yeah make sense, @mshudrak should I change it?
Up to you, I don't have strong preference. Why did you close PR? :) We still need to merge it
@mshudrak alright all changes are done, sorry closed it by a silly mistake.
LGTM
Description
Added types to args along with long names for all commands
Changes Made
changes in scanner.py
Checklist
Feel free to modify and customize this template as needed to fit the specific needs of the GCP Scanner project.