search

google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
311 stars 97 forks source link

BUG: Output is appended for each scan on a single project #79

Closed peb-peb closed 1 year ago

peb-peb commented 1 year ago

Current behavior -> The output is appended to the same JSON file every time we scan the same SA.

maybe we could try the following:

For reference, I am running the following command multiple times- gcp-scanner -l INFO -o output -k /home/peb/Downloads

Am0stafa commented 1 year ago

Hi @peb-peb! I'm interested in tackling this issue and I think I have the necessary skills to make a contribution. Would it be possible to assign this issue to me? I believe with some guidance and support, I'll be able to make meaningful progress and work towards a solution. Thank you for considering my request!

peb-peb commented 1 year ago

Sure, go ahead with this and submit a draft PR. Also, we don't assign issues, you can comment and start working on the issue. This way, others would know that you are working on the issue.

peb-peb commented 1 year ago

Also, I'm also working around this on my local machine, so if you need any assistance, be sure to tag me :)

3V3RYONE commented 1 year ago

Hello @Am0stafa and @peb-peb, I was actually working on this issue since past two days and I have made the PR now. Sorry to not let you know earlier. I really do not want to stop you from working on this issue. Feel free to add any changes/commits in my PR as a collaborator if you wish to.

Hope you do not mind it. Thank you :)

Am0stafa commented 1 year ago

Actual the reason I asked to get assigned is that i don't work on something someone else is working on, I'm completely new to open source usually i do solo projects or work on with a team on a project but the way i see it is someone gets assigned an issue for 2-3 days and if nothing is reached someone else gets assigned.

Am0stafa commented 1 year ago

but overall @3V3RYONE solution was great and I learned from it and that's actually the goal is to learn either from my solution or someone else's solution and I believe that there is no competition and that we all are working toward the same goal which is making this project better

peb-peb commented 1 year ago

@mshudrak I'd like to work on this issue if the current PR is no longer being actively worked on. Should I move forward with this?

3V3RYONE commented 1 year ago

Just got a bit caught up with semester examinations. Will do the required work within a day

peb-peb commented 1 year ago

Ok! No problem :)