google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
305 stars 94 forks source link

Code refactoring #86

Closed RahulDubey391 closed 1 year ago

RahulDubey391 commented 1 year ago

Description

Class declaration for Crawler functions in crawl.py

Changes Made

  1. Separated functions and segregated to appropriate Class names.
  2. Separation of duties for each class

Checklist

Related Issues

2

Additional Notes

The classes restructuring is just a proposal. For implementation success, scanner.py has to create and use the object's methods for success. Also tests needs to be changed to consider object level testing.

Feel free to modify and customize this template as needed to fit the specific needs of the GCP Scanner project.

mshudrak commented 1 year ago

Hmm, we have conflict that need to be addressed now. For some reason, our tests are completely disabled in this PR. Please check why this PR is not covered by our tests now.

RahulDubey391 commented 1 year ago

Hi @mshudrak , I noticed that the test didn't happened. I think maybe the Pull request is same as before one which got accepted for merging. I'll close this one maybe and open new one with some other name.