google / gcp_scanner

A comprehensive scanner for Google Cloud
Apache License 2.0
305 stars 94 forks source link

Update CONTRIBUTING.md #97

Closed ro4i7 closed 1 year ago

ro4i7 commented 1 year ago

Description

[Update CONTRIBUTING.md .]

Changes Made

[i have updated the CONTRIBUTING.md as necessary ]

Checklist

Related Issues

[If your changes relate to any existing issues, please list them here.]

Additional Notes

[Provide any additional notes or context that may be helpful for the reviewers.]

Feel free to modify and customize this template as needed to fit the specific needs of the GCP Scanner project.

ro4i7 commented 1 year ago

Hello, @ZetaTwo I have updated. if there is any issue, please tag me. Thank you.

mshudrak commented 1 year ago

Please resolve the conflict. We had quite similar PR recently merged.

ro4i7 commented 1 year ago

Please resolve the conflict. We had quite similar PR recently merged.

yeah, resolved the conflict. I have done this PR yesterday, but I committed to two solutions in a single PR.

ro4i7 commented 1 year ago

Please resolve the conflict. We had quite similar PR recently merged.

yeah, resolved the conflict. I have done this PR yesterday, but I committed to two solutions in a single PR.

if possible, please merge it to the main.

ro4i7 commented 1 year ago

@mshudrak @ZetaTwo resolved the changes. Please check.

ro4i7 commented 1 year ago

I am not sure I am following what you want to change with that PR. Are you sure we need that change at all?

@mshudrak Changed, please check.