search

google / gdata-python-client

444 stars 228 forks source link

Correct exit code if number of errors % 256 == 0 #6

Closed lamby closed 9 years ago

lamby commented 9 years ago

For example, we had 256 errors (etc.) our process will exit with a successful error code which is incorrect and/or misleading.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

lamby commented 9 years ago

Signed.

googlebot commented 9 years ago

CLAs look good, thanks!

aliafshar commented 9 years ago

Hi, thanks for this. I prefer explicly setting the error to 1 or 0

lamby commented 9 years ago

Hi, thanks for this. I prefer explicly setting the error to 1 or 0

Fair. Updated.

aliafshar commented 9 years ago

Thanks :+1: