google / gematria

Machine learning for machine code.
Apache License 2.0
70 stars 11 forks source link

Incompatibility with Python 3.12 #122

Closed virajbshah closed 2 months ago

virajbshah commented 3 months ago

Python 3.12 supports only TensorFlow 2.16 - which drops the tf.estimator API, used by the current version of tensorflow-ranking used in Gematria. Until tensorflow-ranking gains compatibility with TensorFlow 2.16 (and hence Python 3.12), we'll have to stick with Python 3.11 and TensorFlow 2.15.

ondrasej commented 3 months ago

A few thoughts on this:

WDYT? And would you like to take a look at this?

virajbshah commented 3 months ago

Removing tensorlow-ranking should be an easy choice if the ranking loss is not very effective, especially since it'll make installation/set-up a little simpler since there won't be a separate process for MacOS.

I can look into it, but I think it will stay low priority since it isn't blocking anything (other than TF 2.16).

virajbshah commented 3 months ago

Turns out removing tfr was very straightforward. I have left the PR (#128) with the corresponding changes as a draft in case we think any further discussion about whether it should be kept around or not is in order.

boomanaiden154 commented 3 months ago

It seems reasonable enough to me, and not being able to upgrade to TF 2.16 I think is pretty good motivation to just remove the functionality. I'd say open the PR for review and ping reviewers.

virajbshah commented 2 months ago

Fixed by PR #128