google / gematria

Machine learning for machine code.
Apache License 2.0
76 stars 11 forks source link

Move loop register into BlockAnnotations #166

Closed boomanaiden154 closed 3 months ago

boomanaiden154 commented 3 months ago

convert_bhive_to_llvm_exegesis_input before this patch stored the loop_register separately. Having the annotators add the loop register to the annotations gives more flexibility down the line for exactly specifying how the block was executed in the annotator/should be benchmarked. Additionally, a register chosen for use as a loop counter is fundamentally an annotation, so placing it there makes more sense from the abstraction perspective.

boomanaiden154 commented 3 months ago

This is a stacked PR on top of:

  1. 165