search

google / gemma.cpp

lightweight, standalone C++ inference engine for Google's Gemma models.
Apache License 2.0
5.9k stars 499 forks source link

work with cmake install #169

Closed xinpingwang closed 4 months ago

xinpingwang commented 4 months ago

currently, gemma only works at build dir, it better to support cmake --install to install the build output to system directory and easy to use gemma globally. I made two changes:

  1. allow gemma and libgemma to be install;
  2. change target_link_libraries of sentencepiece to sentencepiece-static, so that the build output is portable
xinpingwang commented 4 months ago

Thank you!

Could you help release a new version after this pr merged. so that I can create a new formula for homebrew Homebrew/homebrew-core#166881

jan-wassenberg commented 4 months ago

Apologies, I did not see that this PR targets the main branch, thus our import automation failed. Would you please change it to dev? Soon after it lands in dev, we can do a release.

xinpingwang commented 4 months ago

Apologies, I did not see that this PR targets the main branch, thus our import automation failed. Would you please change it to dev? Soon after it lands in dev, we can do a release.

ok, updated.

jan-wassenberg commented 4 months ago

Thanks! Restarted the import.

xinpingwang commented 4 months ago

Merged success to dev, could you help release a new version. Thanks.

jan-wassenberg commented 4 months ago

Yes, we will do one soon :)