google / gemma_pytorch

The official PyTorch implementation of Google's Gemma models
https://ai.google.dev/gemma
Apache License 2.0
5.19k stars 492 forks source link

fix: raise Exception #49

Open leowzz opened 4 months ago

leowzz commented 4 months ago

To ensure that the exception is handled correctly, raise should be used instead of return

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

pengchongjin commented 3 months ago

Thanks for the contribution, could you please sign the CLA to proceed?