search

google / gemma_pytorch

The official PyTorch implementation of Google's Gemma models
https://ai.google.dev/gemma
Apache License 2.0
5.24k stars 499 forks source link

Add utility to convert string to boolean type to fix quant parse arg #6

Closed nakkapeddi closed 6 months ago

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

pengchongjin commented 6 months ago

Thanks for your solution.

I pushed a slight different fix. Please let me know if that can work for you. Thanks! https://github.com/google/gemma_pytorch/commit/5f2c166bd7bdd24daa868a827cfbec3bb5405ef3

nakkapeddi commented 6 months ago

@pengchongjin Works for me, thank you! Closing this.