google / gf180mcu-pdk

PDK for GlobalFoundries' 180nm MCU bulk process technology (GF180MCU).
https://gf180mcu-pdk.rtfd.io
Apache License 2.0
364 stars 53 forks source link

Wrong commands in LEF file #106

Open thesourcerer8 opened 1 year ago

thesourcerer8 commented 1 year ago

Expected Behavior

The LEF files should be conforming to the fileformat specification

Actual Behavior

There are wrong commands in the LEF files: grafik

thesourcerer8 commented 1 year ago

gf180mcu_fd_sc_mcu9t5v0__antennaDIFFAREA should be ANTENNADIFFAREA instead.

thesourcerer8 commented 1 year ago

Somehow ANTENNA was replaced by with the antenna cell name, perhaps a TCL scope variable override issue?

QuantamHD commented 1 year ago

Nice catch, we'll get a fix in.

RTimothyEdwards commented 1 year ago

This is essentially a duplicate of #104, since the same string replacement caused both.

mithro commented 1 year ago

I believe this is fixed by https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_sc_mcu9t5v0/pull/23

umarcor commented 1 year ago

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_sc_mcu9t5v0/pull/23 was merged. Can this be closed?

thesourcerer8 commented 1 year ago

Can I get these changes into the gfmpw-0d Caravel branch, or will this go into a different branch (which one?), or is there another way to get this fix into a repo with gfmpw-0d ?

QuantamHD commented 1 year ago

@jeffdi @RTimothyEdwards

RTimothyEdwards commented 1 year ago

This fix has been in open_pdks since three weeks ago, and by extension should be in volare. It does not specifically "go into" the caravel repository, although the various commit numbers recorded for the library repositories should all be up-to-date.