google / ghc-source-gen

Library for generating Haskell source files and code fragments.
BSD 3-Clause "New" or "Revised" License
91 stars 29 forks source link

Request for new release #104

Closed Vekhir closed 11 months ago

Vekhir commented 11 months ago

Hi, The current master branch supports GHC 9.4, but there was no release to hackage. This effectively blocks Arch Linux from upgrading to newer versions of GHC.

Please make a new release including the support for GHC 9.4. Are there specific roadblocks preventing a release at this time? I also saw another PR for GHC 9.6 support.

Gratefully, Vekhir

blackgnezdo commented 11 months ago

I can do the pushes, but first I need help (or find the time) to fix the CI and extend it to support 9.4. I don't want to push something which I don't know keeps working as we make more changes.

ysangkok commented 11 months ago

@blackgnezdo Is the current CircleCI working and are its results publicly accessible?

blackgnezdo commented 11 months ago

We got one now as part of #107.

blackgnezdo commented 11 months ago

I mean we got a CI. @jinwoo could you do a release or add me as a co-maintainer on hackage?

jinwoo commented 11 months ago

I just uploaded to hackage. Fortunately I still have stack on my laptop :)

I don't think I can add other people as co-maintainers. Last time, I emailed to the hackage folks and cc'd Judah. Once Judah confirmed he was okay with me as a co-maintainer, they added me. Maybe you can do the same, @blackgnezdo ?

ysangkok commented 11 months ago

@jinwoo Since you are listed as a maintainer yourself, you can add Hackage maintainers from this page, which also lists all current maintainers: https://hackage.haskell.org/package/ghc-source-gen/maintainers/

See the edit link at the end of the line.

You will have to put in gnezdo as the user.

jinwoo commented 11 months ago

@ysangkok Good to know. Thanks! @blackgnezdo I added you as a maintainer.

Vekhir commented 11 months ago

Also thanks from me! The update works nicely.