search

google / ghc-source-gen

Library for generating Haskell source files and code fragments.
BSD 3-Clause "New" or "Revised" License
91 stars 29 forks source link

Add standaloneDeriving #81

Closed ersran9 closed 3 years ago

blackgnezdo commented 3 years ago

@ersran9 I looked more closely, could you fix the unused import?

ghc-source-gen      > [24 of 27] Compiling GHC.SourceGen.Decl
ghc-source-gen      > 
ghc-source-gen      > /home/circleci/project/src/GHC/SourceGen/Decl.hs:59:1: error: [-Wunused-imports, -Werror=unused-imports]
ghc-source-gen      >     The import of ‘HsWildCardBndrs’
ghc-source-gen      >     from module ‘GHC.Hs.Types’ is redundant
ghc-source-gen      >    |
ghc-source-gen      > 59 | import GHC.Hs.Types
ghc-source-gen      >    | ^^^^^^^^^^^^^^^^^^^...
ghc-source-gen      >
ersran9 commented 3 years ago

There is a warning that I missed out, let me push again with that removed.

ersran9 commented 3 years ago

Whew - that's what I get for trying to use cabal on a stack project. Also, I just noticed that build-ghc-8.10 on CI actually runs the command stack test --no-terminal --resolver=lts-15.13 - which uses ghc-8.8.3.

blackgnezdo commented 3 years ago

@judah, this looks like an improvement to me, so I'll merge it and we can fix up later if need be.