search

google / gif-for-cli

https://opensource.googleblog.com/2018/06/tenor-gif-for-cli.html
Apache License 2.0
2.93k stars 161 forks source link

Python3 devel requirement #3

Closed jcubic closed 6 years ago

jcubic commented 6 years ago

The readme needs updating with this requirement if you don't install python devel it will fail to compile because of missing Python.h file.

SeanHayes commented 6 years ago

Is it Pillow that fails to compile? What platform are you on?

jcubic commented 6 years ago

I've lost my console output, because I've run the app in the same terminal. I'm on Fedora. invoking 

sudo dnf isntall python3-devel

solved the problem.

jcubic commented 6 years ago

I can remove the package and see what's failing if you want.

SeanHayes commented 6 years ago

Does your Python env have wheel support? If so I think pip should install a precompiled version of Pillow, if not, then it'll try to compile from source.

jcubic commented 6 years ago

How can I test this? I've called pip3 install --user wheel and it was installed.

SeanHayes commented 6 years ago

It'll be hard to untangle the cause now that everything is installed. I'll add a note to the README that python-dev/python-devel may be required.