Open SASUPERNOVA opened 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
What's the status of this PR and https://github.com/google/gif-for-cli/pull/35? I tried using gif-for-cli because it looks interesting, but it seems currently completely broken. It looks like all that needs to be done is for @SASUPERNOVA to sign the CLA, correct?
Currently,
_save_config
is not includingrows
option in its iteration. As a result,scale_height
becomes 0, which in turn causes issue Can't use gif-for-cli (Float division by zero on execute.py). This patch includesrows
option to fix this issue.