search

google / git-appraise-web

Web UI for git-appraise
Apache License 2.0
216 stars 23 forks source link

webkit only? #1

Open linquize opened 8 years ago

linquize commented 8 years ago

Currently it works only on webkit-based browser such as Chrome. Firefox, IE, Edge do not work. This is because Polymer is used.

ojarjur commented 8 years ago

I'll admit that we may have issues with older browsers ( Polymer only claims to support the latest two versions of every major browser ).

However, If you are seeing an issue with other browsers, then it's more likely my fault rather than Polymer.

That's because I have not tested it on any browser but Chrome, so I may have done something stupid that breaks other browsers.

Regardless, I'll try it out on some other browsers as soon as I can get a hold of them.

Thanks for bringing this to my attention.

MichaelMure commented 8 years ago

The body has a computed height of 0px, so a blank page is shown.

ojarjur commented 8 years ago

A quick update: I haven't gotten a chance to test on Edge or Safari yet, but opening the UI in Firefox showed that I had done something stupid.

Specifically, I was using the polyfills library to try to support browsers that don't yet natively support Polymer, but I was not using it correctly. I had the link to load that library but was not waiting until it was ready before trying to register my Polymer components.

2 fixes that, and I've updated the demo site to use the new code.

Thanks again for pointing this out, and if you see any more compatibility issues, then please let me know.

ojarjur commented 8 years ago

I'm keeping this open until I can confirm it works in the other browsers (at least Safari and Edge).

linquize commented 8 years ago

With #2, Edge works. IE11 repo list ok, but review open list and review close list are empty.

ojarjur commented 8 years ago

@linquize Thanks for checking and for catching that issue with IE11.

I looked and it turns out that I had missed one spot (in the review lists) where I needed to make sure the webcomponents library was loaded before the polymer components were used.

That bug will be fixed with #3 (and I've already updated the demo to incorporate that fix).

linquize commented 8 years ago

3 reviews.html still not work with IE11.

ojarjur commented 8 years ago

@linquize Thanks for following up and reporting that.

I'll still submit #3 since it is fixing a bug, but I'll leave this open until I can get a hold of an instance of IE11, and can dig into what is going wrong.