google / git-appraise

Distributed code review system for Git repos

Apache License 2.0

5.12k stars 145 forks source link

feat: support date option and date relate env #110

Closed fatelei closed 2 years ago

fatelei commented 2 years ago

109

add command option -date
add env GIT_AUTHOR_DATE, GIT_COMMITTER_DATE

fatelei commented 2 years ago

only support timestamp format

ojarjur commented 2 years ago

Thanks so much for the contribution!

I'm taking a look now and will have some feedback, but overall this looks like a big help.

ojarjur commented 2 years ago

Thanks again for the contribution!

Aside from not wanting to make backwards-incompatible changes to comment.New and request.New, this looks great!

fatelei commented 2 years ago

Mirror pull requests into git-notes / Mirror (pull_request_review) has failed

ojarjur commented 2 years ago

@fatelei Don't worry about the failed mirror action. That's not a presubmit check but rather just an export step to make sure the PR data is all in git notes.

This PR itself looks good and I'll merge it now. Thanks for all your work on this!