search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.14k stars 146 forks source link

Possible bug fix for thread comment status #23

Open hazbo opened 8 years ago

hazbo commented 8 years ago

As pointed out in #22, the status for every comment seems to be fyi. This seems to fix that.

barbastan commented 8 years ago

Thanks!

Barbara

On Wednesday, December 23, 2015, Harry Lawrence notifications@github.com wrote:

As pointed out in #22 https://github.com/google/git-appraise/issues/22, the status for every comment seems to be fyi.

This seems to fix that.

You can view, comment on, or merge this pull request online at:

https://github.com/google/git-appraise/pull/23 Commit Summary

  • Possible bug fix for thread comment status

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/google/git-appraise/pull/23.

hazbo commented 8 years ago

This may now be redundant as of #24

ojarjur commented 8 years ago

There's the overall status of the entire sub-thread, and the resolved bit for the individual comment. Right now we are only displaying the overall status.

I wouldn't want to replace the overall status with the individual comment's status (which is what this PR currently does), but I would not object to displaying both statuses if we can format the output nicely.