google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.14k stars 146 forks source link

Fixed updateThreadsStatus to modify original thread instances, rather than modifying copies #24

Closed jishi9 closed 8 years ago

jishi9 commented 8 years ago

This is a proposed fix to #22

updateThreadsStatus was not actually updating the CommentThread instances, but updating copies thereof.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jishi9 commented 8 years ago

I signed it!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

ojarjur commented 8 years ago

Thanks for doing this; good catch on the bug.