search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.14k stars 146 forks source link

Parent comment hash is not validated #25

Closed jishi9 closed 8 years ago

jishi9 commented 8 years ago

The command below falsely succeeds, even though the parent hash is invalid: git appraise comment -p anyArbitraryString -m 'some message'

These orphan comments seem to end up in the object referenced by .git/refs/notes/devtools/discuss:

$ git appraise comment -p anyArbitraryString -m message1
$ git appraise comment -p anything -m message2
$ git appraise comment -p blah -m message3

$ cat .git/refs/notes/devtools/discuss
963045ca0ab34dcd5917fec785beddff37dc997d

$ git show 963045ca0ab34dcd5917fec785beddff37dc997d
 {"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"someArbitraryString","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message1","resolved":false}

 {"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"anything","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message2","resolved":false}
+
+{"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"blah","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message3","resolved":false}
barbastan commented 8 years ago

Good catch. Thanks!

Barbara

On Wed, Dec 23, 2015 at 4:40 PM, jishi9 notifications@github.com wrote:

The command below falsely succeeds, even thought the parent hash is invalid: git appraise comment -p anyArbitraryString -m 'some message'

These orphan comments seem to end up in the object referenced by .git/refs/notes/devtools/discuss:

$ git appraise comment -p anyArbitraryString -m message1 $ git appraise comment -p anything -m message2 $ git appraise comment -p blah -m message3

$ cat .git/refs/notes/devtools/discuss 963045ca0ab34dcd5917fec785beddff37dc997d

$ git show 963045ca0ab34dcd5917fec785beddff37dc997d {"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"someArbitraryString","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message1","resolved":false}

{"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"anything","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message2","resolved":false} + +{"timestamp":"$TIMESTAMP","author":"$AUTHOR","parent":"blah","location":{"commit":"c685f115aa84e8bf7b795eceaf38b95fc0b18414"},"description":"message3","resolved":false}

— Reply to this email directly or view it on GitHub https://github.com/google/git-appraise/issues/25.