search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.14k stars 146 forks source link

Check that parent comment exists before creating a comment #27

Closed jishi9 closed 8 years ago

jishi9 commented 8 years ago

A proposed fix to issue #25

Would be nice to be able to instead use the commentsByHash that is already computed in review.loadComments. Suggestions welcome!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

barbastan commented 8 years ago

Omar will look at this when he returns on Jan. 4th.

Thanks! Barbara

On Sat, Dec 26, 2015 at 1:16 PM, googlebot notifications@github.com wrote:

CLAs look good, thanks!

— Reply to this email directly or view it on GitHub https://github.com/google/git-appraise/pull/27#issuecomment-167363884.