search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.14k stars 146 forks source link

$EDITOR with args isn't working #30

Closed the-kenny closed 8 years ago

the-kenny commented 8 years ago

My EDITOR is set to emacsclient -tty. This works fine with all common command line tools. It fails in git appraise with the following message:

Unable to start editor: exec: "emacsclient -tty": executable file not found in $PATH

ojarjur commented 8 years ago

Thanks for the report.

Right now we're taking the value of the editor var, and just trying to execute it, so that obviously won't work here. I'll look into how the stock git commands invoke the editor, and try to more accurately emulate what they do.

ojarjur commented 8 years ago

So, the stock git commands use a shell to launch the editor. However, they do so differently on windows vs. non-windows.

This will be hard to cleanly do in a cross-platform way. However, on the bright side, it might also fix the issue that @linquize reported.

I'll try some ideas and see if any of them work.

ojarjur commented 8 years ago

This should be fixed with the latest change. I tested it with my editor set to "emacsclient -q" and did not see any issues.

If it still isn't working, then please re-open this issue.