google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.13k stars 146 forks source link

make the JSON-schema usable #40

Closed andreineculau closed 8 years ago

andreineculau commented 8 years ago

see commit messages

ojarjur commented 8 years ago

Thanks so much for doing this; this looks like a major improvement in the documentation of the spec!

I've posted some feedback about the required fields, but overall this looks really good.

FYI, I'm not at my computer much this week, so I may be slow to respond (or unavailable) until next Monday. Sorry for that delay, and thanks again for the help.

andreineculau commented 8 years ago

@ojarjur I hope the new commit solves everything. but take it easy on yourself, carpe diem :) this will still be here years from now :)