search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.12k stars 145 forks source link

Added abandon command #68

Closed sokolovstas closed 7 years ago

sokolovstas commented 7 years ago

This commit resolve #17

Added abandon command that add comment with resolve = false and remove TargetRef from Request. Added edit note command to git.go repository to update existing note. Added abandon status to output.go when Request.TargetRef is empty.

ojarjur commented 7 years ago

Thanks for taking the time and putting in the effort to help improve the tool.

I really appreciate it.

sokolovstas commented 7 years ago

I fixed all comments! Thank you for you reviews!

But I have one problem and can't figure it out. Abandon comment is not saved to the note.

ojarjur commented 7 years ago

@sokolovstas You're absolutely right. I overlooked the name of the flag in the abandon command.

If you fix that then it should work.

Thanks again for your help!