search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.12k stars 145 forks source link

Any plan to support authorization on reviewers ? #84

Closed lktslionel closed 6 years ago

lktslionel commented 6 years ago

Hello, Is there any plan to support authorization on reviewers ? Could we choose who has the right to reviews code ?

Or you let this part to the Git provider ? Thanks

ojarjur commented 6 years ago

Thanks for reaching out and asking.

In short; no, that is not in scope for this tool.

The reviews are stored in git, so the set of people who are allowed to push a review to a repository are the set of peopled who are allowed to push to the refs/notes/devtools/* refs in that repository.

git-appraise operates entirely on the client side, so all decisions on who is or is not allowed to push to the remote repository are left to the git server (e.g. the git hosting provider if you are using a hosting provider).

A git server (or git hosting provider) could choose to provide fine-grained control over who can update those refs, but that is out of scope for the git-appraise tool.